change staticRNN to while #48213
Merged
change staticRNN to while #48213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove_recurrent_op_and_static_rnn_api
|
你的PR提交成功，感谢你对开源项目的贡献! |
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
[bugfix] fix _find_op_path_ bugs in append_backward.
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
zhiqiu
reviewed
Dec 12, 2022
Comment on lines
+443
to
+458
| auto shape = var_desc->GetShape(); | ||
| VLOG(8) << "Found uninitialized tensor " << outside_og_name | ||
| << " in step 0, fill it with 0.0f. dims=" | ||
| << phi::make_ddim(shape); | ||
| framework::AttributeMap attrs; | ||
| attrs["dtype"] = var_desc->GetDataType(); | ||
| attrs["shape"] = phi::vectorize<int>(phi::make_ddim(shape)); | ||
| attrs["value"] = 0.0f; | ||
|
|
||
| auto var_name = outside_og_name; | ||
| auto zero_op = | ||
| framework::OpRegistry::CreateOp("fill_constant", | ||
| framework::VariableNameMap{}, | ||
| {{"Out", {var_name}}}, | ||
| attrs); | ||
| zero_op->Run(scope, dev_place); |
There was a problem hiding this comment.
Better to use SetConstant or Full API directly.
There was a problem hiding this comment.
这个逻辑上可以改成full_like； 但是
- while op内部没有数据类型的T，需要使用visitor
- full like的api的dense tensor是返回值， 要摁到scope里面，还需要一些操作
这种方式改完，逻辑比当前还要复杂
| auto &og_outside = *scope.FindVar(outside_og_name); | ||
| auto &og_inside = *cur_scope.Var(inside_og_name); | ||
| if (og_outside.IsType<phi::DenseTensor>()) { | ||
| auto &outside_tensor = og_outside.Get<phi::DenseTensor>(); | ||
| auto &inside_tensor = *og_inside.GetMutable<phi::DenseTensor>(); | ||
| inside_tensor.set_lod(outside_tensor.lod()); | ||
| inside_tensor.ShareDataWith(outside_tensor); | ||
| if (outside_tensor.IsInitialized()) { |
There was a problem hiding this comment.
Is this line needed after set zero added?
There was a problem hiding this comment.
shoule be removed here
zhiqiu
reviewed
Dec 12, 2022
| auto is_var_input_and_output = | ||
| std::find(outside_og_names.begin(), | ||
| outside_og_names.end(), | ||
| pg_ig_names[param_id]) != outside_og_names.end(); |
There was a problem hiding this comment.
原来是获取一个iterator，现在是把iterator的判断提前
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
… remove_recurrent_op_and_static_rnn_api
zhiqiu
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
我们计划移除recurrent op 和 StaticRNN，将paddle.nn.RNN中依赖的staticRNN替换为while